Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02a606c2 authored by roel kluin's avatar roel kluin Committed by Benjamin Herrenschmidt
Browse files

powerpc: Missing tests for NULL after ioremap() 



Missing tests after ioremap()

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent cf68787b

arch/powerpc/platforms/powermac/feature.c

+8 −1
Original line number Diff line number Diff line
@@ -2589,9 +2589,16 @@ static void __init probe_uninorth(void) 
	if (address == 0)

		return;

	uninorth_base = ioremap(address, 0x40000);

	if (uninorth_base == NULL)

		return;

	uninorth_rev = in_be32(UN_REG(UNI_N_VERSION));

	if (uninorth_maj == 3 || uninorth_maj == 4)

	if (uninorth_maj == 3 || uninorth_maj == 4) {

		u3_ht_base = ioremap(address + U3_HT_CONFIG_BASE, 0x1000);

		if (u3_ht_base == NULL) {

			iounmap(uninorth_base);

			return;

		}

	}



	printk(KERN_INFO "Found %s memory controller & host bridge"

	       " @ 0x%08x revision: 0x%02x\n", uninorth_maj == 3 ? "U3" :