Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fd3da12d authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by David S. Miller
Browse files

netxen_nic: Mark expected switch fall-throughs 



In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1410182 ("Missing break in switch")
Addresses-Coverity-ID: 1410183 ("Missing break in switch")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 53a42286

drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -167,9 +167,9 @@ netxen_nic_get_link_ksettings(struct net_device *dev, 
	case NETXEN_BRDTYPE_P3_REF_QG:

	case NETXEN_BRDTYPE_P3_REF_QG:

	case NETXEN_BRDTYPE_P3_4_GB:

	case NETXEN_BRDTYPE_P3_4_GB:

	case NETXEN_BRDTYPE_P3_4_GB_MM:

	case NETXEN_BRDTYPE_P3_4_GB_MM:



		supported |= SUPPORTED_Autoneg;

		supported |= SUPPORTED_Autoneg;

		advertising |= ADVERTISED_Autoneg;

		advertising |= ADVERTISED_Autoneg;

		/* fall through */

	case NETXEN_BRDTYPE_P2_SB31_10G_CX4:

	case NETXEN_BRDTYPE_P2_SB31_10G_CX4:

	case NETXEN_BRDTYPE_P3_10G_CX4:

	case NETXEN_BRDTYPE_P3_10G_CX4:

	case NETXEN_BRDTYPE_P3_10G_CX4_LP:

	case NETXEN_BRDTYPE_P3_10G_CX4_LP:
@@ -198,6 +198,7 @@ netxen_nic_get_link_ksettings(struct net_device *dev, 
		supported |= SUPPORTED_TP;

		supported |= SUPPORTED_TP;

		check_sfp_module = netif_running(dev) &&

		check_sfp_module = netif_running(dev) &&

			adapter->has_link_events;

			adapter->has_link_events;

		/* fall through */

	case NETXEN_BRDTYPE_P2_SB31_10G:

	case NETXEN_BRDTYPE_P2_SB31_10G:

	case NETXEN_BRDTYPE_P3_10G_XFP:

	case NETXEN_BRDTYPE_P3_10G_XFP:

		supported |= SUPPORTED_FIBRE;

		supported |= SUPPORTED_FIBRE;