Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53a42286 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by David S. Miller
Browse files

qed: qed_dev: Mark expected switch fall-throughs 



In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case, I replaced the code comments with
a proper "fall through" annotation, which is what GCC is expecting
to find.

Addresses-Coverity-ID: 114809 ("Missing break in switch")
Addresses-Coverity-ID: 114810 ("Missing break in switch")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e77f02b8

drivers/net/ethernet/qlogic/qed/qed_dev.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -1789,14 +1789,14 @@ int qed_hw_init(struct qed_dev *cdev, struct qed_hw_init_params *p_params) 
						p_hwfn->hw_info.hw_mode);

						p_hwfn->hw_info.hw_mode);

			if (rc)

			if (rc)

				break;

				break;

		/* Fall into */

		/* Fall through */

		case FW_MSG_CODE_DRV_LOAD_PORT:

		case FW_MSG_CODE_DRV_LOAD_PORT:

			rc = qed_hw_init_port(p_hwfn, p_hwfn->p_main_ptt,

			rc = qed_hw_init_port(p_hwfn, p_hwfn->p_main_ptt,

					      p_hwfn->hw_info.hw_mode);

					      p_hwfn->hw_info.hw_mode);

			if (rc)

			if (rc)

				break;

				break;





		/* Fall into */

		/* Fall through */

		case FW_MSG_CODE_DRV_LOAD_FUNCTION:

		case FW_MSG_CODE_DRV_LOAD_FUNCTION:

			rc = qed_hw_init_pf(p_hwfn, p_hwfn->p_main_ptt,

			rc = qed_hw_init_pf(p_hwfn, p_hwfn->p_main_ptt,

					    p_params->p_tunn,

					    p_params->p_tunn,