Commit fbdab3e7 authored Feb 24, 2017 by Colin Ian King Committed by Martin K. Petersen Feb 27, 2017

scsi: aacraid: remove redundant zero check on ret



The check for ret being zero is redundant as a few statements earlier we
break out of the while loop if ret is non-zero.  Thus we can remove the
zero check and also the dead-code non-zero case too.

Detected by CoverityScan, CID#1411632 ("Logically Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Dave Carroll <david.carroll@microsemi.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 825c6abb

drivers/scsi/aacraid/commsup.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -2508,8 +2508,7 @@ int aac_command_thread(void *data)
		&& (now.tv_usec > (1000000 / HZ)))
		difference = (((1000000 - now.tv_usec) * HZ)
		+ 500000) / 1000000;
		else if (ret == 0) {

		else {
		if (now.tv_usec > 500000)
		++now.tv_sec;

		@@ -2520,9 +2519,6 @@ int aac_command_thread(void *data)
		ret = aac_send_hosttime(dev, &now);

		difference = (long)(unsigned)update_interval*HZ;
		} else {
		/* retry shortly */
		difference = 10 * HZ;
		}
		next_jiffies = jiffies + difference;
		if (time_before(next_check_jiffies,next_jiffies))