Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fabd3ab6 authored by Yu Liao's avatar Yu Liao Committed by Greg Kroah-Hartman
Browse files

net: thunderx: Fix the ACPI memory leak 



[ Upstream commit 661e5ebbafd26d9d2e3c749f5cf591e55c7364f5 ]

The ACPI buffer memory (string.pointer) should be freed as the buffer is
not used after returning from bgx_acpi_match_id(), free it to prevent
memory leak.

Fixes: 46b903a0 ("net, thunder, bgx: Add support to get MAC address from ACPI.")
Signed-off-by: default avatarYu Liao <liaoyu15@huawei.com>
Link: https://lore.kernel.org/r/20221123082237.1220521-1-liaoyu15@huawei.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 1633e6d6

drivers/net/ethernet/cavium/thunder/thunder_bgx.c

+3 −1
Original line number Diff line number Diff line
@@ -1438,8 +1438,10 @@ static acpi_status bgx_acpi_match_id(acpi_handle handle, u32 lvl, 
		return AE_OK;

	}



	if (strncmp(string.pointer, bgx_sel, 4))

	if (strncmp(string.pointer, bgx_sel, 4)) {

		kfree(string.pointer);

		return AE_OK;

	}



	acpi_walk_namespace(ACPI_TYPE_DEVICE, handle, 1,

			    bgx_acpi_register_phy, NULL, bgx, NULL);