Commit 1633e6d6 authored Nov 21, 2022 by Martin Faltesek Committed by Greg Kroah-Hartman Dec 08, 2022

nfc: st-nci: fix memory leaks in EVT_TRANSACTION



[ Upstream commit 440f2ae9c9f06e26f5dcea697a53717fc61a318c ]

Error path does not free previously allocated memory. Add devm_kfree() to
the failure path.

Reported-by: Denis Efremov <denis.e.efremov@oracle.com>
Reviewed-by: Guenter Roeck <groeck@google.com>
Fixes: 5d1ceb7f ("NFC: st21nfcb: Add HCI transaction event support")
Signed-off-by: Martin Faltesek <mfaltesek@google.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 0e2a4560

drivers/nfc/st-nci/se.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -341,8 +341,10 @@ static int st_nci_hci_connectivity_event_received(struct nci_dev *ndev,

		/* Check next byte is PARAMETERS tag (82) */
		if (skb->data[transaction->aid_len + 2] !=
		NFC_EVT_TRANSACTION_PARAMS_TAG)
		NFC_EVT_TRANSACTION_PARAMS_TAG) {
		devm_kfree(dev, transaction);
		return -EPROTO;
		}

		transaction->params_len = skb->data[transaction->aid_len + 3];
		memcpy(transaction->params, skb->data +