Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f777cda3 authored by Axel Lin's avatar Axel Lin Committed by Linus Walleij
Browse files

gpio: amd-fch: Set proper output level for direction_output 



Current amd_fch_gpio_direction_output implementation ignores the value
argument, fix it so direction_output will set proper output level.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: default avatarEnrico Weigelt <info@metux.net>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent deb63b0b

drivers/gpio/gpio-amd-fch.c

+10 −1
Original line number Diff line number Diff line
@@ -65,9 +65,18 @@ static int amd_fch_gpio_direction_output(struct gpio_chip *gc, 
	unsigned long flags;

	struct amd_fch_gpio_priv *priv = gpiochip_get_data(gc);

	void __iomem *ptr = amd_fch_gpio_addr(priv, gpio);

	u32 val;



	spin_lock_irqsave(&priv->lock, flags);

	writel_relaxed(readl_relaxed(ptr) | AMD_FCH_GPIO_FLAG_DIRECTION, ptr);



	val = readl_relaxed(ptr);

	if (value)

		val |= AMD_FCH_GPIO_FLAG_WRITE;

	else

		val &= ~AMD_FCH_GPIO_FLAG_WRITE;



	writel_relaxed(val | AMD_FCH_GPIO_FLAG_DIRECTION, ptr);



	spin_unlock_irqrestore(&priv->lock, flags);



	return 0;