Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit ef9d5a6a authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Paul Burton
Browse files

mips: math-emu: no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Paul Burton <paul.burton@mips.com>
Cc: James Hogan <jhogan@kernel.org>
Cc: Yangtao Li <tiny.windzz@gmail.com>
Cc: linux-mips@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarPaul Burton <paul.burton@mips.com>
parent 864cc363

arch/mips/math-emu/me-debugfs.c

+4 −19
Original line number Original line Diff line number Diff line
@@ -189,32 +189,21 @@ static int __init debugfs_fpuemu(void) 
{

{

	struct dentry *fpuemu_debugfs_base_dir;

	struct dentry *fpuemu_debugfs_base_dir;

	struct dentry *fpuemu_debugfs_inst_dir;

	struct dentry *fpuemu_debugfs_inst_dir;

	struct dentry *d, *reset_file;



	if (!mips_debugfs_dir)

		return -ENODEV;





	fpuemu_debugfs_base_dir = debugfs_create_dir("fpuemustats",

	fpuemu_debugfs_base_dir = debugfs_create_dir("fpuemustats",

						     mips_debugfs_dir);

						     mips_debugfs_dir);

	if (!fpuemu_debugfs_base_dir)

		return -ENOMEM;





	reset_file = debugfs_create_file("fpuemustats_clear", 0444,

	debugfs_create_file("fpuemustats_clear", 0444, mips_debugfs_dir, NULL,

					 mips_debugfs_dir, NULL,

			    &fpuemustats_clear_fops);

			    &fpuemustats_clear_fops);

	if (!reset_file)

		return -ENOMEM;





#define FPU_EMU_STAT_OFFSET(m)						\

#define FPU_EMU_STAT_OFFSET(m)						\

	offsetof(struct mips_fpu_emulator_stats, m)

	offsetof(struct mips_fpu_emulator_stats, m)





#define FPU_STAT_CREATE(m)						\

#define FPU_STAT_CREATE(m)						\

do {									\

do {									\

	d = debugfs_create_file(#m, 0444, fpuemu_debugfs_base_dir,	\

	debugfs_create_file(#m, 0444, fpuemu_debugfs_base_dir,		\

				(void *)FPU_EMU_STAT_OFFSET(m),		\

				(void *)FPU_EMU_STAT_OFFSET(m),		\

				&fops_fpuemu_stat);			\

				&fops_fpuemu_stat);			\

	if (!d)								\

		return -ENOMEM;						\

} while (0)

} while (0)





	FPU_STAT_CREATE(emulated);

	FPU_STAT_CREATE(emulated);
@@ -233,8 +222,6 @@ do { \ 




	fpuemu_debugfs_inst_dir = debugfs_create_dir("instructions",

	fpuemu_debugfs_inst_dir = debugfs_create_dir("instructions",

						     fpuemu_debugfs_base_dir);

						     fpuemu_debugfs_base_dir);

	if (!fpuemu_debugfs_inst_dir)

		return -ENOMEM;





#define FPU_STAT_CREATE_EX(m)						\

#define FPU_STAT_CREATE_EX(m)						\

do {									\

do {									\
@@ -242,11 +229,9 @@ do { \ 
									\

									\

	adjust_instruction_counter_name(name, #m);			\

	adjust_instruction_counter_name(name, #m);			\

									\

									\

	d = debugfs_create_file(name, 0444, fpuemu_debugfs_inst_dir,	\

	debugfs_create_file(name, 0444, fpuemu_debugfs_inst_dir,	\

				(void *)FPU_EMU_STAT_OFFSET(m),		\

				(void *)FPU_EMU_STAT_OFFSET(m),		\

				&fops_fpuemu_stat);			\

				&fops_fpuemu_stat);			\

	if (!d)								\

		return -ENOMEM;						\

} while (0)

} while (0)





	FPU_STAT_CREATE_EX(abs_s);

	FPU_STAT_CREATE_EX(abs_s);