Unverified Commit 864cc363 authored Jan 22, 2019 by Greg Kroah-Hartman Committed by Paul Burton Jan 22, 2019

mips: mm: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Paul Burton <paul.burton@mips.com>
Cc: James Hogan <jhogan@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-mips@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paul Burton <paul.burton@mips.com>

parent 4c90de4d

arch/mips/mm/sc-debugfs.c

+3 −12

Original line number	Diff line number	Diff line
		@@ -55,20 +55,11 @@ static const struct file_operations sc_prefetch_fops = {

		static int __init sc_debugfs_init(void)
		{
		struct dentry dir, file;

		if (!mips_debugfs_dir)
		return -ENODEV;
		struct dentry *dir;

		dir = debugfs_create_dir("l2cache", mips_debugfs_dir);
		if (IS_ERR(dir))
		return PTR_ERR(dir);

		file = debugfs_create_file("prefetch", S_IRUGO \| S_IWUSR, dir,
		NULL, &sc_prefetch_fops);
		if (!file)
		return -ENOMEM;

		debugfs_create_file("prefetch", S_IRUGO \| S_IWUSR, dir, NULL,
		&sc_prefetch_fops);
		return 0;
		}
		late_initcall(sc_debugfs_init);