Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e24cf6b3 authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller
Browse files

net: dsa: b53: Don't assign autonegotiation enabled 



PHYLINK takes care of filing the right information into
state->an_enabled, get rid of the read from the SerDes's BMCR register.

Fixes: 0e01491d ("net: dsa: b53: Add SerDes support")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5b9b0a80

drivers/net/dsa/b53/b53_serdes.c

+1 −4
Original line number Diff line number Diff line
@@ -100,15 +100,13 @@ int b53_serdes_link_state(struct b53_device *dev, int port, 
			  struct phylink_link_state *state)

{

	u8 lane = b53_serdes_map_lane(dev, port);

	u16 dig, bmcr, bmsr;

	u16 dig, bmsr;



	if (lane == B53_INVALID_LANE)

		return 1;



	dig = b53_serdes_read(dev, lane, B53_SERDES_DIGITAL_STATUS,

			      SERDES_DIGITAL_BLK);

	bmcr = b53_serdes_read(dev, lane, B53_SERDES_MII_REG(MII_BMCR),

			       SERDES_MII_BLK);

	bmsr = b53_serdes_read(dev, lane, B53_SERDES_MII_REG(MII_BMSR),

			       SERDES_MII_BLK);
@@ -129,7 +127,6 @@ int b53_serdes_link_state(struct b53_device *dev, int port, 
	}



	state->duplex = dig & DUPLEX_STATUS ? DUPLEX_FULL : DUPLEX_HALF;

	state->an_enabled = !!(bmcr & BMCR_ANENABLE);

	state->an_complete = !!(bmsr & BMSR_ANEGCOMPLETE);

	state->link = !!(dig & LINK_STATUS);

	if (dig & PAUSE_RESOLUTION_RX_SIDE)