Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e1dc68a4 authored by Claudiu Beznea's avatar Claudiu Beznea Committed by Sam Ravnborg
Browse files

drm: atmel-hlcdc: avoid initializing cfg with zero 



Remove cfg initialization with zero and read state with
drm_crtc_state_to_atmel_hlcdc_crtc_state() so that cfg to be initialized
with state's output_mode.

Signed-off-by: default avatarClaudiu Beznea <claudiu.beznea@microchip.com>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/1556195748-11106-3-git-send-email-claudiu.beznea@microchip.com
parent a6eca2ab

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c

+2 −4
Original line number Diff line number Diff line
@@ -138,7 +138,8 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c) 


	regmap_update_bits(regmap, ATMEL_HLCDC_CFG(0), mask, cfg);



	cfg = 0;

	state = drm_crtc_state_to_atmel_hlcdc_crtc_state(c->state);

	cfg = state->output_mode << 8;



	if (adj->flags & DRM_MODE_FLAG_NVSYNC)

		cfg |= ATMEL_HLCDC_VSPOL;
@@ -146,9 +147,6 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c) 
	if (adj->flags & DRM_MODE_FLAG_NHSYNC)

		cfg |= ATMEL_HLCDC_HSPOL;



	state = drm_crtc_state_to_atmel_hlcdc_crtc_state(c->state);

	cfg |= state->output_mode << 8;



	regmap_update_bits(regmap, ATMEL_HLCDC_CFG(5),

			   ATMEL_HLCDC_HSPOL | ATMEL_HLCDC_VSPOL |

			   ATMEL_HLCDC_VSPDLYS | ATMEL_HLCDC_VSPDLYE |