Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit df7f160d authored by Kyle Zeng's avatar Kyle Zeng Committed by Lee Jones
Browse files

UPSTREAM: ipv4: fix null-deref in ipv4_link_failure



[ Upstream commit 0113d9c9d1ccc07f5a3710dac4aa24b6d711278c ]

Currently, we assume the skb is associated with a device before calling
__ip_options_compile, which is not always the case if it is re-routed by
ipvs.
When skb->dev is NULL, dev_net(skb->dev) will become null-dereference.
This patch adds a check for the edge case and switch to use the net_device
from the rtable when skb->dev is NULL.

Bug: 304913674
Fixes: ed0de45a ("ipv4: recompile ip options in ipv4_link_failure")
Suggested-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarKyle Zeng <zengyhkyle@gmail.com>
Cc: Stephen Suryaputra <ssuryaextr@gmail.com>
Cc: Vadim Fedorenko <vfedorenko@novek.ru>
Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
(cherry picked from commit 2712545e535d7a2e4c53b9c9658a9c88c6055862)
Signed-off-by: default avatarLee Jones <joneslee@google.com>
Change-Id: Ie840ff3351e487f7095c49fac4fdd1e81021a982
parent 91f70257
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment