Commit deef33c0 authored Mar 15, 2023 by Wei Chen Committed by Greg Kroah-Hartman Apr 05, 2023

fbdev: lxfb: Fix potential divide by zero



[ Upstream commit 61ac4b86a4c047c20d5cb423ddd87496f14d9868 ]

var->pixclock can be assigned to zero by user. Without proper
check, divide by zero would occur in lx_set_clock.

Error out if var->pixclock is zero.

Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 4f5cc5ff

drivers/video/fbdev/geode/lxfb_core.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -234,6 +234,9 @@ static void get_modedb(struct fb_videomode *modedb, unsigned int size)

		static int lxfb_check_var(struct fb_var_screeninfo var, struct fb_info info)
		{
		if (!var->pixclock)
		return -EINVAL;

		if (var->xres > 1920 \|\| var->yres > 1440)
		return -EINVAL;