Commit 4f5cc5ff authored Mar 15, 2023 by Wei Chen Committed by Greg Kroah-Hartman Apr 05, 2023

fbdev: intelfb: Fix potential divide by zero



[ Upstream commit d823685486a3446d061fed7c7d2f80af984f119a ]

Variable var->pixclock is controlled by user and can be assigned
to zero. Without proper check, divide by zero would occur in
intelfbhw_validate_mode and intelfbhw_mode_to_hw.

Error out if var->pixclock is zero.

Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 868f247e

drivers/video/fbdev/intelfb/intelfbdrv.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1214,6 +1214,9 @@ static int intelfb_check_var(struct fb_var_screeninfo *var,

		dinfo = GET_DINFO(info);

		if (!var->pixclock)
		return -EINVAL;

		/* update the pitch */
		if (intelfbhw_validate_mode(dinfo, var) != 0)
		return -EINVAL;