Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d8f6382a authored by Ross Lagerwall's avatar Ross Lagerwall Committed by Martin K. Petersen
Browse files

Revert "scsi: libfc: Add WARN_ON() when deleting rports" 



This reverts commit bbc0f8bd.

It added a warning whose intent was to check whether the rport was still
linked into the peer list. It doesn't work as intended and gives false
positive warnings for two reasons:

1) If the rport is never linked into the peer list it will not be
considered empty since the list_head is never initialized.

2) If the rport is deleted from the peer list using list_del_rcu(), then
the list_head is in an undefined state and it is not considered empty.

Signed-off-by: default avatarRoss Lagerwall <ross.lagerwall@citrix.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 88fc41c4

drivers/scsi/libfc/fc_rport.c

+0 −1
Original line number Diff line number Diff line
@@ -184,7 +184,6 @@ void fc_rport_destroy(struct kref *kref) 
	struct fc_rport_priv *rdata;



	rdata = container_of(kref, struct fc_rport_priv, kref);

	WARN_ON(!list_empty(&rdata->peers));

	kfree_rcu(rdata, rcu);

}

EXPORT_SYMBOL(fc_rport_destroy);