Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bbc0f8bd authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Martin K. Petersen
Browse files

scsi: libfc: Add WARN_ON() when deleting rports 



The discovery rport list handling is quite odd; the list traversal is
independent from the lifetime of the rport itself. This makes auditing
quite tricky, and the chance remains that we've missed something.  So this
patch adds a WARN_ON() statement when freeing an rport which is still part
of a list.

Signed-off-by: default avatarHannes Reinecke <hare@suse.com>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent bc3d12b7

drivers/scsi/libfc/fc_rport.c

+1 −0
Original line number Diff line number Diff line
@@ -184,6 +184,7 @@ void fc_rport_destroy(struct kref *kref) 
	struct fc_rport_priv *rdata;



	rdata = container_of(kref, struct fc_rport_priv, kref);

	WARN_ON(!list_empty(&rdata->peers));

	kfree_rcu(rdata, rcu);

}

EXPORT_SYMBOL(fc_rport_destroy);