Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d869a189 authored by Zhang Changzhong's avatar Zhang Changzhong Committed by Greg Kroah-Hartman
Browse files

wifi: brcmfmac: fix potential memory leak in brcmf_netdev_start_xmit() 



[ Upstream commit 212fde3fe76e962598ce1d47b97cc78afdfc71b3 ]

The brcmf_netdev_start_xmit() returns NETDEV_TX_OK without freeing skb
in case of pskb_expand_head() fails, add dev_kfree_skb() to fix it.
Compile tested only.

Fixes: 270a6c1f ("brcmfmac: rework headroom check in .start_xmit()")
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
Reviewed-by: default avatarArend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/1668684782-47422-1-git-send-email-zhangchangzhong@huawei.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a12610e8

drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c

+1 −0
Original line number Diff line number Diff line
@@ -333,6 +333,7 @@ static netdev_tx_t brcmf_netdev_start_xmit(struct sk_buff *skb, 
			bphy_err(drvr, "%s: failed to expand headroom\n",

				 brcmf_ifname(ifp));

			atomic_inc(&drvr->bus_if->stats.pktcow_failed);

			dev_kfree_skb(skb);

			goto done;

		}

	}