Commit a12610e8 authored Nov 17, 2022 by Zhang Changzhong Committed by Greg Kroah-Hartman Mar 11, 2023

wifi: wilc1000: fix potential memory leak in wilc_mac_xmit()



[ Upstream commit deb962ec9e1c9a81babd3d37542ad4bd6ac3396e ]

The wilc_mac_xmit() returns NETDEV_TX_OK without freeing skb, add
dev_kfree_skb() to fix it. Compile tested only.

Fixes: c5c77ba1 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/1668684964-48622-1-git-send-email-zhangchangzhong@huawei.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent a6059cf0

drivers/staging/wilc1000/wilc_netdev.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -717,6 +717,7 @@ netdev_tx_t wilc_mac_xmit(struct sk_buff skb, struct net_device ndev)

		if (skb->dev != ndev) {
		netdev_err(ndev, "Packet not destined to this device\n");
		dev_kfree_skb(skb);
		return NETDEV_TX_OK;
		}