Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d1c7d97a authored by Sasha Levin's avatar Sasha Levin Committed by Al Viro
Browse files

fs: handle failed audit_log_start properly 



audit_log_start() may return NULL, this is unchecked by the caller in
audit_log_link_denied() and could cause a NULL ptr deref.

Introduced by commit a51d9eaa ("fs: add link restriction audit reporting").

Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent ffd8d101

kernel/audit.c

+2 −0
Original line number Diff line number Diff line
@@ -1440,6 +1440,8 @@ void audit_log_link_denied(const char *operation, struct path *link) 


	ab = audit_log_start(current->audit_context, GFP_KERNEL,

			     AUDIT_ANOM_LINK);

	if (!ab)

		return;

	audit_log_format(ab, "op=%s action=denied", operation);

	audit_log_format(ab, " pid=%d comm=", current->pid);

	audit_log_untrustedstring(ab, current->comm);