Commit ffd8d101 authored Oct 04, 2012 by Sasha Levin Committed by Al Viro Oct 09, 2012

fs: prevent use after free in auditing when symlink following was denied



Commit "fs: add link restriction audit reporting" has added auditing of failed
attempts to follow symlinks. Unfortunately, the auditing was being done after
the struct path structure was released earlier.

Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 547b1e81

fs/namei.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -692,9 +692,9 @@ static inline int may_follow_link(struct path link, struct nameidata nd)
		if (uid_eq(parent->i_uid, inode->i_uid))
		return 0;

		audit_log_link_denied("follow_link", link);
		path_put_conditional(link, nd);
		path_put(&nd->path);
		audit_log_link_denied("follow_link", link);
		return -EACCES;
		}