Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0209bba authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

wifi: mwl8k: initialize cmd->addr[] properly 



[ Upstream commit 1d60eabb82694e58543e2b6366dae3e7465892a5 ]

This loop is supposed to copy the mac address to cmd->addr but the
i++ increment is missing so it copies everything to cmd->addr[0] and
only the last address is recorded.

Fixes: 22bedad3 ("net: convert multicast list to list_head")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://msgid.link/b788be9a-15f5-4cca-a3fe-79df4c8ce7b2@moroto.mountain


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a7500167

drivers/net/wireless/marvell/mwl8k.c

+1 −1
Original line number Diff line number Diff line
@@ -2714,7 +2714,7 @@ __mwl8k_cmd_mac_multicast_adr(struct ieee80211_hw *hw, int allmulti, 
		cmd->action |= cpu_to_le16(MWL8K_ENABLE_RX_MULTICAST);

		cmd->numaddr = cpu_to_le16(mc_count);

		netdev_hw_addr_list_for_each(ha, mc_list) {

			memcpy(cmd->addr[i], ha->addr, ETH_ALEN);

			memcpy(cmd->addr[i++], ha->addr, ETH_ALEN);

		}

	}