Commit cfb5bbfc authored Oct 17, 2022 by Yang Yingliang Committed by Greg Kroah-Hartman Jan 18, 2023

powerpc/xive: add missing iounmap() in error path in xive_spapr_populate_irq_data()



[ Upstream commit 8b49670f3bb3f10cd4d5a6dca17f5a31b173ecdc ]

If remapping 'data->trig_page' fails, the 'data->eoi_mmio' need be unmapped
before returning from xive_spapr_populate_irq_data().

Fixes: eac1e731 ("powerpc/xive: guest exploitation of the XIVE interrupt controller")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20221017032333.1852406-1-yangyingliang@huawei.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent f2d60f6b

arch/powerpc/sysdev/xive/spapr.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -422,6 +422,7 @@ static int xive_spapr_populate_irq_data(u32 hw_irq, struct xive_irq_data *data)

		data->trig_mmio = ioremap(data->trig_page, 1u << data->esb_shift);
		if (!data->trig_mmio) {
		iounmap(data->eoi_mmio);
		pr_err("Failed to map trigger page for irq 0x%x\n", hw_irq);
		return -ENOMEM;
		}