Commit f2d60f6b authored Jun 05, 2022 by Miaoqian Lin Committed by Greg Kroah-Hartman Jan 18, 2023

cxl: Fix refcount leak in cxl_calc_capp_routing



[ Upstream commit 1d09697ff22908ae487fc8c4fbde1811732be523 ]

of_get_next_parent() returns a node pointer with refcount incremented,
we should use of_node_put() on it when not need anymore.
This function only calls of_node_put() in normal path,
missing it in the error path.
Add missing of_node_put() to avoid refcount leak.

Fixes: f24be42a ("cxl: Add psl9 specific code")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220605060038.62217-1-linmq006@gmail.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 9bf842ff

drivers/misc/cxl/pci.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -387,6 +387,7 @@ int cxl_calc_capp_routing(struct pci_dev dev, u64 chipid,
		rc = get_phb_index(np, phb_index);
		if (rc) {
		pr_err("cxl: invalid phb index\n");
		of_node_put(np);
		return rc;
		}