Commit c8eabf82 authored Oct 13, 2016 by Dan Carpenter Committed by Mark Brown Oct 26, 2016

ASoC: Intel: Skylake: Fix a shift wrapping bug



"*val" is a u64.  It definitely looks like we intend to use the high 32
bits as well.

Fixes: 700a9a63 ("ASoC: Intel: Skylake: Add module instance id generation APIs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Tested-by: Kranthi G <gudishax.kranthikumar@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent d5bc18c1

sound/soc/intel/skylake/skl-sst-utils.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -179,7 +179,7 @@ static inline int skl_getid_32(struct uuid_module module, u64 val,
		index = ffz(mask_val);
		pvt_id = index + word1_mask + word2_mask;
		if (pvt_id <= (max_inst - 1)) {
		*val \|= 1 << (index + word1_mask);
		*val \|= 1ULL << (index + word1_mask);
		return pvt_id;
		}
		}