Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c8a4452d authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

xprtrdma: fix incorrect header size calculations 



[ Upstream commit 912288442cb2f431bf3c8cb097a5de83bc6dbac1 ]

Currently the header size calculations are using an assignment
operator instead of a += operator when accumulating the header
size leading to incorrect sizes.  Fix this by using the correct
operator.

Addresses-Coverity: ("Unused value")
Fixes: 302d3deb ("xprtrdma: Prevent inline overflow")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a75a8aab

net/sunrpc/xprtrdma/rpc_rdma.c

+2 −2
Original line number Diff line number Diff line
@@ -71,7 +71,7 @@ static unsigned int rpcrdma_max_call_header_size(unsigned int maxsegs) 
	size = RPCRDMA_HDRLEN_MIN;



	/* Maximum Read list size */

	size = maxsegs * rpcrdma_readchunk_maxsz * sizeof(__be32);

	size += maxsegs * rpcrdma_readchunk_maxsz * sizeof(__be32);



	/* Minimal Read chunk size */

	size += sizeof(__be32);	/* segment count */
@@ -96,7 +96,7 @@ static unsigned int rpcrdma_max_reply_header_size(unsigned int maxsegs) 
	size = RPCRDMA_HDRLEN_MIN;



	/* Maximum Write list size */

	size = sizeof(__be32);		/* segment count */

	size += sizeof(__be32);		/* segment count */

	size += maxsegs * rpcrdma_segment_maxsz * sizeof(__be32);

	size += sizeof(__be32);	/* list discriminator */