Commit c0b8cff0 authored Nov 04, 2022 by Yang Yingliang Committed by Greg Kroah-Hartman Jan 18, 2023

MIPS: vpe-cmp: fix possible memory leak while module exiting



[ Upstream commit c5ed1fe0801f0c66b0fbce2785239a5664629057 ]

dev_set_name() allocates memory for name, it need be freed
when module exiting, call put_device() to give up reference,
so that it can be freed in kobject_cleanup() when the refcount
hit to 0. The vpe_device is static, so remove kfree() from
vpe_device_release().

Fixes: 17a1d523 ("MIPS: APRP: Add VPE loader support for CMP platforms.")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent b3325a44

arch/mips/kernel/vpe-cmp.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -75,7 +75,6 @@ ATTRIBUTE_GROUPS(vpe);

		static void vpe_device_release(struct device *cd)
		{
		kfree(cd);
		}

		static struct class vpe_class = {
		@@ -157,6 +156,7 @@ int __init vpe_module_init(void)
		device_del(&vpe_device);

		out_class:
		put_device(&vpe_device);
		class_unregister(&vpe_class);

		out_chrdev:
		@@ -169,7 +169,7 @@ void __exit vpe_module_exit(void)
		{
		struct vpe v, n;

		device_del(&vpe_device);
		device_unregister(&vpe_device);
		class_unregister(&vpe_class);
		unregister_chrdev(major, VPE_MODULE_NAME);