Commit b3325a44 authored Nov 04, 2022 by Yang Yingliang Committed by Greg Kroah-Hartman Jan 18, 2023

MIPS: vpe-mt: fix possible memory leak while module exiting



[ Upstream commit 5822e8cc84ee37338ab0bdc3124f6eec04dc232d ]

Afer commit 1fa5ae85 ("driver core: get rid of struct device's
bus_id string array"), the name of device is allocated dynamically,
it need be freed when module exiting, call put_device() to give up
reference, so that it can be freed in kobject_cleanup() when the
refcount hit to 0. The vpe_device is static, so remove kfree() from
vpe_device_release().

Fixes: 1fa5ae85 ("driver core: get rid of struct device's bus_id string array")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 7c8bf45c

arch/mips/kernel/vpe-mt.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -313,7 +313,6 @@ ATTRIBUTE_GROUPS(vpe);

		static void vpe_device_release(struct device *cd)
		{
		kfree(cd);
		}

		static struct class vpe_class = {
		@@ -497,6 +496,7 @@ int __init vpe_module_init(void)
		device_del(&vpe_device);

		out_class:
		put_device(&vpe_device);
		class_unregister(&vpe_class);

		out_chrdev:
		@@ -509,7 +509,7 @@ void __exit vpe_module_exit(void)
		{
		struct vpe v, n;

		device_del(&vpe_device);
		device_unregister(&vpe_device);
		class_unregister(&vpe_class);
		unregister_chrdev(major, VPE_MODULE_NAME);