Commit c03304dc authored Jun 01, 2022 by Miaoqian Lin Committed by Greg Kroah-Hartman Jun 22, 2022

misc: atmel-ssc: Fix IRQ check in ssc_probe



[ Upstream commit 1c245358ce0b13669f6d1625f7a4e05c41f28980 ]

platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes: eb1f2930 ("Driver for the Atmel on-chip SSC on AT32AP and AT91")
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220601123026.7119-1-linmq006@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent f7183c76

drivers/misc/atmel-ssc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -232,9 +232,9 @@ static int ssc_probe(struct platform_device *pdev)
		clk_disable_unprepare(ssc->clk);

		ssc->irq = platform_get_irq(pdev, 0);
		if (!ssc->irq) {
		if (ssc->irq < 0) {
		dev_dbg(&pdev->dev, "could not get irq\n");
		return -ENXIO;
		return ssc->irq;
		}

		mutex_lock(&user_lock);