Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f7183c76 authored by Vincent Whitchurch's avatar Vincent Whitchurch Committed by Greg Kroah-Hartman
Browse files

tty: goldfish: Fix free_irq() on remove 



[ Upstream commit 499e13aac6c762e1e828172b0f0f5275651d6512 ]

Pass the correct dev_id to free_irq() to fix this splat when the driver
is unbound:

 WARNING: CPU: 0 PID: 30 at kernel/irq/manage.c:1895 free_irq
 Trying to free already-free IRQ 65
 Call Trace:
  warn_slowpath_fmt
  free_irq
  goldfish_tty_remove
  platform_remove
  device_remove
  device_release_driver_internal
  device_driver_detach
  unbind_store
  drv_attr_store
  ...

Fixes: 465893e1 ("tty: goldfish: support platform_device with id -1")
Signed-off-by: default avatarVincent Whitchurch <vincent.whitchurch@axis.com>
Link: https://lore.kernel.org/r/20220609141704.1080024-1-vincent.whitchurch@axis.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ff6e03fe

drivers/tty/goldfish.c

+1 −1
Original line number Diff line number Diff line
@@ -428,7 +428,7 @@ static int goldfish_tty_remove(struct platform_device *pdev) 
	tty_unregister_device(goldfish_tty_driver, qtty->console.index);

	iounmap(qtty->base);

	qtty->base = NULL;

	free_irq(qtty->irq, pdev);

	free_irq(qtty->irq, qtty);

	tty_port_destroy(&qtty->port);

	goldfish_tty_current_line_count--;

	if (goldfish_tty_current_line_count == 0)