Commit bc509951 authored Apr 25, 2023 by Vijaya Krishna Nivarthi Committed by Greg Kroah-Hartman Jul 27, 2023

spi: spi-geni-qcom: Correct CS_TOGGLE bit in SPI_TRANS_CFG



[ Upstream commit 5fd7c99ecf45c8ee8a9b1268f0ffc91cc6271da2 ]

The CS_TOGGLE bit when set is supposed to instruct FW to
toggle CS line between words. The driver with intent of
disabling this behaviour has been unsetting BIT(0). This has
not caused any trouble so far because the original BIT(1)
is untouched and BIT(0) likely wasn't being used.

Correct this to prevent a potential future bug.

Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Fixes: 561de45f ("spi: spi-geni-qcom: Add SPI driver support for GENI based QUP")
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/1682412128-1913-1-git-send-email-quic_vnivarth@quicinc.com


Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent f394d204

drivers/spi/spi-geni-qcom.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -32,7 +32,7 @@
		#define CS_DEMUX_OUTPUT_SEL GENMASK(3, 0)

		#define SE_SPI_TRANS_CFG 0x25c
		#define CS_TOGGLE BIT(0)
		#define CS_TOGGLE BIT(1)

		#define SE_SPI_WORD_LEN 0x268
		#define WORD_LEN_MSK GENMASK(9, 0)