Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f394d204 authored by Pengcheng Yang's avatar Pengcheng Yang Committed by Greg Kroah-Hartman
Browse files

samples/bpf: Fix buffer overflow in tcp_basertt 



[ Upstream commit f4dea9689c5fea3d07170c2cb0703e216f1a0922 ]

Using sizeof(nv) or strlen(nv)+1 is correct.

Fixes: c890063e ("bpf: sample BPF_SOCKET_OPS_BASE_RTT program")
Signed-off-by: default avatarPengcheng Yang <yangpc@wangsu.com>
Link: https://lore.kernel.org/r/1683276658-2860-1-git-send-email-yangpc@wangsu.com


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 90e3c101

samples/bpf/tcp_basertt_kern.c

+1 −1
Original line number Diff line number Diff line
@@ -47,7 +47,7 @@ int bpf_basertt(struct bpf_sock_ops *skops) 
		case BPF_SOCK_OPS_BASE_RTT:

			n = bpf_getsockopt(skops, SOL_TCP, TCP_CONGESTION,

					   cong, sizeof(cong));

			if (!n && !__builtin_memcmp(cong, nv, sizeof(nv)+1)) {

			if (!n && !__builtin_memcmp(cong, nv, sizeof(nv))) {

				/* Set base_rtt to 80us */

				rv = 80;

			} else if (n) {