Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ba87d137 authored by Lior Amsalem's avatar Lior Amsalem Committed by Vinod Koul
Browse files

dma: mv_xor: Reduce interrupts by enabling EOD only when needed 



This commit unmasks the end-of-chain interrupt and removes the
end-of-descriptor command setting on all transactions, except those
explicitly flagged with DMA_PREP_INTERRUPT.

This allows to raise an interrupt only on chain completion, instead of
on each descriptor completion, which reduces interrupt count.

Signed-off-by: default avatarLior Amsalem <alior@marvell.com>
Signed-off-by: default avatarEzequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 0e7488ed

drivers/dma/mv_xor.c

+10 −4
Original line number Diff line number Diff line
@@ -46,13 +46,16 @@ static void mv_xor_issue_pending(struct dma_chan *chan); 
	((chan)->dmadev.dev)



static void mv_desc_init(struct mv_xor_desc_slot *desc,

			 dma_addr_t addr, u32 byte_count)

			 dma_addr_t addr, u32 byte_count,

			 enum dma_ctrl_flags flags)

{

	struct mv_xor_desc *hw_desc = desc->hw_desc;



	hw_desc->status = XOR_DESC_DMA_OWNED;

	hw_desc->phy_next_desc = 0;

	hw_desc->desc_command = XOR_DESC_EOD_INT_EN;

	/* Enable end-of-descriptor interrupts only for DMA_PREP_INTERRUPT */

	hw_desc->desc_command = (flags & DMA_PREP_INTERRUPT) ?

				XOR_DESC_EOD_INT_EN : 0;

	hw_desc->phy_dest_addr = addr;

	hw_desc->byte_count = byte_count;

}
@@ -107,7 +110,10 @@ static u32 mv_chan_get_intr_cause(struct mv_xor_chan *chan) 


static void mv_xor_device_clear_eoc_cause(struct mv_xor_chan *chan)

{

	u32 val = ~(XOR_INT_END_OF_DESC	<< (chan->idx * 16));

	u32 val;



	val = XOR_INT_END_OF_DESC | XOR_INT_END_OF_CHAIN | XOR_INT_STOPPED;

	val = ~(val << (chan->idx * 16));

	dev_dbg(mv_chan_to_devp(chan), "%s, val 0x%08x\n", __func__, val);

	writel_relaxed(val, XOR_INTR_CAUSE(chan));

}
@@ -510,7 +516,7 @@ mv_xor_prep_dma_xor(struct dma_chan *chan, dma_addr_t dest, dma_addr_t *src, 
	if (sw_desc) {

		sw_desc->type = DMA_XOR;

		sw_desc->async_tx.flags = flags;

		mv_desc_init(sw_desc, dest, len);

		mv_desc_init(sw_desc, dest, len, flags);

		sw_desc->unmap_src_cnt = src_cnt;

		sw_desc->unmap_len = len;

		while (src_cnt--)

drivers/dma/mv_xor.h

+1 −1
Original line number Diff line number Diff line
@@ -67,7 +67,7 @@ 
				 XOR_INT_ERR_WRPROT | XOR_INT_ERR_OWN    | \

				 XOR_INT_ERR_PAR    | XOR_INT_ERR_MBUS)



#define XOR_INTR_MASK_VALUE	(XOR_INT_END_OF_DESC | \

#define XOR_INTR_MASK_VALUE	(XOR_INT_END_OF_DESC | XOR_INT_END_OF_CHAIN | \

				 XOR_INT_STOPPED     | XOR_INTR_ERRORS)



#define WINDOW_BASE(w)		(0x50 + ((w) << 2))