Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b948ff8a authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

mfd: max77620: Fix refcount leak in max77620_initialise_fps 



[ Upstream commit 1520669c8255bd637c6b248b2be910e2688d38dd ]

of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: 327156c5 ("mfd: max77620: Add core driver for MAX77620/MAX20024")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20220601043222.64441-1-linmq006@gmail.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 8d01edaf

drivers/mfd/max77620.c

+2 −0
Original line number Diff line number Diff line
@@ -418,9 +418,11 @@ static int max77620_initialise_fps(struct max77620_chip *chip) 
		ret = max77620_config_fps(chip, fps_child);

		if (ret < 0) {

			of_node_put(fps_child);

			of_node_put(fps_np);

			return ret;

		}

	}

	of_node_put(fps_np);



	config = chip->enable_global_lpm ? MAX77620_ONOFFCNFG2_SLP_LPM_MSK : 0;

	ret = regmap_update_bits(chip->rmap, MAX77620_REG_ONOFFCNFG2,