Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d01edaf authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman
Browse files

mfd: t7l66xb: Drop platform disable callback 



[ Upstream commit 128ac294e1b437cb8a7f2ff8ede1cde9082bddbe ]

None of the in-tree instantiations of struct t7l66xb_platform_data
provides a disable callback. So better don't dereference this function
pointer unconditionally. As there is no user, drop it completely instead
of calling it conditional.

This is a preparation for making platform remove callbacks return void.

Fixes: 1f192015 ("mfd: driver for the T7L66XB TMIO SoC")
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20220530192430.2108217-3-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent b45bcdf6

drivers/mfd/t7l66xb.c

+1 −5
Original line number Diff line number Diff line
@@ -405,11 +405,8 @@ static int t7l66xb_probe(struct platform_device *dev) 


static int t7l66xb_remove(struct platform_device *dev)

{

	struct t7l66xb_platform_data *pdata = dev_get_platdata(&dev->dev);

	struct t7l66xb *t7l66xb = platform_get_drvdata(dev);

	int ret;



	ret = pdata->disable(dev);

	clk_disable_unprepare(t7l66xb->clk48m);

	clk_put(t7l66xb->clk48m);

	clk_disable_unprepare(t7l66xb->clk32k);
@@ -420,8 +417,7 @@ static int t7l66xb_remove(struct platform_device *dev) 
	mfd_remove_devices(&dev->dev);

	kfree(t7l66xb);



	return ret;



	return 0;

}



static struct platform_driver t7l66xb_platform_driver = {

include/linux/mfd/t7l66xb.h

+0 −1
Original line number Diff line number Diff line
@@ -12,7 +12,6 @@ 


struct t7l66xb_platform_data {

	int (*enable)(struct platform_device *dev);

	int (*disable)(struct platform_device *dev);

	int (*suspend)(struct platform_device *dev);

	int (*resume)(struct platform_device *dev);