Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6f827c3 authored by Dominique Martinet's avatar Dominique Martinet Committed by Greg Kroah-Hartman
Browse files

9p: virtio: make sure 'offs' is initialized in zc_request 



[ Upstream commit 4a73edab69d3a6623f03817fe950a2d9585f80e4 ]

Similarly to the previous patch: offs can be used in handle_rerrors
without initializing on small payloads; in this case handle_rerrors will
not use it because of the size check, but it doesn't hurt to make sure
it is zero to please scan-build.

This fixes the following warning:
net/9p/trans_virtio.c:539:3: warning: 3rd function call argument is an uninitialized value [core.CallAndMessage]
                handle_rerror(req, in_hdr_len, offs, in_pages);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Signed-off-by: default avatarDominique Martinet <asmadeus@codewreck.org>
Signed-off-by: default avatarEric Van Hensbergen <ericvh@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent b6fefef0

net/9p/trans_virtio.c

+1 −1
Original line number Diff line number Diff line
@@ -394,7 +394,7 @@ p9_virtio_zc_request(struct p9_client *client, struct p9_req_t *req, 
	struct page **in_pages = NULL, **out_pages = NULL;

	struct virtio_chan *chan = client->trans;

	struct scatterlist *sgs[4];

	size_t offs;

	size_t offs = 0;

	int need_drop = 0;

	int kicked = 0;