Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6fefef0 authored by Mario Limonciello's avatar Mario Limonciello Committed by Greg Kroah-Hartman
Browse files

pinctrl: amd: Don't show `Invalid config param` errors 



commit 87b549efcb0f7934b0916d2a00607a878b6f1e0f upstream.

On some systems amd_pinconf_set() is called with parameters
0x8 (PIN_CONFIG_DRIVE_PUSH_PULL) or 0x14 (PIN_CONFIG_PERSIST_STATE)
which are not supported by pinctrl-amd.

Don't show an err message when called with an invalid parameter,
downgrade this to debug instead.

Cc: stable@vger.kernel.org # 6.1
Fixes: 635a750d958e1 ("pinctrl: amd: Use amd_pinconf_set() for all config options")
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20230717201652.17168-1-mario.limonciello@amd.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 99a73016

drivers/pinctrl/pinctrl-amd.c

+2 −2
Original line number Diff line number Diff line
@@ -659,7 +659,7 @@ static int amd_pinconf_get(struct pinctrl_dev *pctldev, 
		break;



	default:

		dev_err(&gpio_dev->pdev->dev, "Invalid config param %04x\n",

		dev_dbg(&gpio_dev->pdev->dev, "Invalid config param %04x\n",

			param);

		return -ENOTSUPP;

	}
@@ -712,7 +712,7 @@ static int amd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin, 
			break;



		default:

			dev_err(&gpio_dev->pdev->dev,

			dev_dbg(&gpio_dev->pdev->dev,

				"Invalid config param %04x\n", param);

			ret = -ENOTSUPP;

		}