Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b61b24bd authored by Tariq Toukan's avatar Tariq Toukan Committed by Saeed Mahameed
Browse files

net/mlx5e: kTLS, Fix page refcnt leak in TX resync error flow 



All references for frag pages that are obtained in tx_sync_info_get()
should be released.
Release usually occurs in the corresponding CQE of the WQE.
In error flows, not all fragments have a WQE posted for them, hence
no matching CQE will be generated.
For these pages, release the reference in the error flow.

Fixes: d2ead1f3 ("net/mlx5e: Add kTLS TX HW offload support")
Signed-off-by: default avatarTariq Toukan <tariqt@mellanox.com>
Reviewed-by: default avatarEran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent 310d9b9d

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c

+5 −2
Original line number Diff line number Diff line
@@ -329,7 +329,7 @@ mlx5e_ktls_tx_handle_ooo(struct mlx5e_ktls_offload_context_tx *priv_tx, 
	struct tx_sync_info info = {};

	u16 contig_wqebbs_room, pi;

	u8 num_wqebbs;

	int i;

	int i = 0;



	if (!tx_sync_info_get(priv_tx, seq, &info)) {

		/* We might get here if a retransmission reaches the driver
@@ -364,7 +364,7 @@ mlx5e_ktls_tx_handle_ooo(struct mlx5e_ktls_offload_context_tx *priv_tx, 


	tx_post_resync_params(sq, priv_tx, info.rcd_sn);



	for (i = 0; i < info.nr_frags; i++)

	for (; i < info.nr_frags; i++)

		if (tx_post_resync_dump(sq, &info.frags[i], priv_tx->tisn, !i))

			goto err_out;
@@ -377,6 +377,9 @@ mlx5e_ktls_tx_handle_ooo(struct mlx5e_ktls_offload_context_tx *priv_tx, 
	return skb;



err_out:

	for (; i < info.nr_frags; i++)

		put_page(skb_frag_page(&info.frags[i]));



	dev_kfree_skb_any(skb);

	return NULL;

}