Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 310d9b9d authored by Tariq Toukan's avatar Tariq Toukan Committed by Saeed Mahameed
Browse files

net/mlx5e: kTLS, Save by-value copy of the record frags 



Access the record fragments only under the TLS ctx lock.
In the resync flow, save a copy of them to be used when
preparing and posting the required DUMP WQEs.

Fixes: d2ead1f3 ("net/mlx5e: Add kTLS TX HW offload support")
Signed-off-by: default avatarTariq Toukan <tariqt@mellanox.com>
Reviewed-by: default avatarEran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent f45da371

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c

+4 −4
Original line number Diff line number Diff line
@@ -179,7 +179,7 @@ struct tx_sync_info { 
	u64 rcd_sn;

	s32 sync_len;

	int nr_frags;

	skb_frag_t *frags[MAX_SKB_FRAGS];

	skb_frag_t frags[MAX_SKB_FRAGS];

};



static bool tx_sync_info_get(struct mlx5e_ktls_offload_context_tx *priv_tx,
@@ -212,11 +212,11 @@ static bool tx_sync_info_get(struct mlx5e_ktls_offload_context_tx *priv_tx, 


		get_page(skb_frag_page(frag));

		remaining -= skb_frag_size(frag);

		info->frags[i++] = frag;

		info->frags[i++] = *frag;

	}

	/* reduce the part which will be sent with the original SKB */

	if (remaining < 0)

		skb_frag_size_add(info->frags[i - 1], remaining);

		skb_frag_size_add(&info->frags[i - 1], remaining);

	info->nr_frags = i;

out:

	spin_unlock_irqrestore(&tx_ctx->lock, flags);
@@ -365,7 +365,7 @@ mlx5e_ktls_tx_handle_ooo(struct mlx5e_ktls_offload_context_tx *priv_tx, 
	tx_post_resync_params(sq, priv_tx, info.rcd_sn);



	for (i = 0; i < info.nr_frags; i++)

		if (tx_post_resync_dump(sq, info.frags[i], priv_tx->tisn, !i))

		if (tx_post_resync_dump(sq, &info.frags[i], priv_tx->tisn, !i))

			goto err_out;



	/* If no dump WQE was sent, we need to have a fence NOP WQE before the