Commit b5c7d4e5 authored Oct 03, 2017 by Dan Carpenter Committed by David S. Miller Oct 03, 2017

mlxsw: spectrum: Add missing error code on allocation failure



We accidentally return success if the kmalloc_array() call fails.

Fixes: 0e14c777 ("mlxsw: spectrum: Add the multicast routing hardware logic")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Yotam Gigi <yotamg@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b508e0b6

drivers/net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -771,8 +771,10 @@ mlxsw_sp_mr_tcam_region_init(struct mlxsw_sp *mlxsw_sp,

		parman_prios = kmalloc_array(MLXSW_SP_MR_ROUTE_PRIO_MAX + 1,
		sizeof(*parman_prios), GFP_KERNEL);
		if (!parman_prios)
		if (!parman_prios) {
		err = -ENOMEM;
		goto err_parman_prios_alloc;
		}
		mr_tcam_region->parman_prios = parman_prios;

		for (i = 0; i < MLXSW_SP_MR_ROUTE_PRIO_MAX + 1; i++)