Commit b508e0b6 authored Oct 03, 2017 by Dan Carpenter Committed by David S. Miller Oct 03, 2017

mlxsw: spectrum: Fix check for IS_ERR() instead of NULL



mlxsw_afa_block_create() doesn't return error pointers, it returns NULL
on error.

Fixes: 0e14c777 ("mlxsw: spectrum: Add the multicast routing hardware logic")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Yotam Gigi <yotamg@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 360cc342

drivers/net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -239,8 +239,8 @@ mlxsw_sp_mr_tcam_afa_block_create(struct mlxsw_sp *mlxsw_sp,
		int err;

		afa_block = mlxsw_afa_block_create(mlxsw_sp->afa);
		if (IS_ERR(afa_block))
		return afa_block;
		if (!afa_block)
		return ERR_PTR(-ENOMEM);

		err = mlxsw_afa_block_append_counter(afa_block, counter_index);
		if (err)