Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b140707f authored by Hemant Kumar's avatar Hemant Kumar
Browse files

mhi: core: Fix undefined reference to `__bad_udelay' 



According to the comment in arch/arm/include/asm/delay.h,
__bad_udelay is specifically designed on ARM to produce a
build failure when udelay is called with a value > 2000.
Fix the issue by using mdelay for value > 2000.

Change-Id: Ia5ee988eeef68ce60b637232e0dd3989b8cbfe64
Signed-off-by: default avatarHemant Kumar <hemantk@codeaurora.org>
parent 77620139

drivers/bus/mhi/core/mhi_boot.c

+7 −7
Original line number Diff line number Diff line
@@ -210,10 +210,10 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl) 
	int ret;

	u32 rx_status;

	enum mhi_ee ee;

	const u32 delayus = 5000;

	u32 retry = (mhi_cntrl->timeout_ms * 1000) / delayus;

	const u32 rddm_timeout_us = 200000;

	int rddm_retry = rddm_timeout_us / delayus; /* time to enter rddm */

	const u32 delayms = 5;

	u32 retry = (mhi_cntrl->timeout_ms) / delayms;

	const u32 rddm_timeout_ms = 200;

	int rddm_retry = rddm_timeout_ms / delayms; /* time to enter rddm */

	void __iomem *base = mhi_cntrl->bhie;



	MHI_CNTRL_LOG("Entered with pm_state:%s dev_state:%s ee:%s\n",
@@ -256,7 +256,7 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl) 
			if (ee == MHI_EE_RDDM)

				break;



			udelay(delayus);

			mdelay(delayms);

		}



		if (rddm_retry <= 0) {
@@ -266,7 +266,7 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl) 
			mhi_cntrl->write_reg(mhi_cntrl, mhi_cntrl->regs,

				      MHI_SOC_RESET_REQ_OFFSET,

				      MHI_SOC_RESET_REQ);

			udelay(delayus);

			mdelay(delayms);

		}



		ee = mhi_get_exec_env(mhi_cntrl);
@@ -287,7 +287,7 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl) 
			return 0;

		}



		udelay(delayus);

		mdelay(delayms);

	}



	ee = mhi_get_exec_env(mhi_cntrl);