Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b0a3fa44 authored by Fuqian Huang's avatar Fuqian Huang Committed by Alexandre Belloni
Browse files

rtc: mxc: use spin_lock_irqsave instead of spin_lock_irq in IRQ context 



As spin_unlock_irq will enable interrupts.
mxc_rtc_irq_enable is called from interrupt handler mxc_rtc_interrupt.
Interrupts are enabled in interrupt handler.
Use spin_lock_irqsave/spin_unlock_irqrestore instead of spin_(un)lock_irq
in IRQ context to avoid this.

Signed-off-by: default avatarFuqian Huang <huangfq.daxian@gmail.com>
Link: https://lore.kernel.org/r/20190807082310.10135-1-huangfq.daxian@gmail.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 41a8e19f

drivers/rtc/rtc-mxc.c

+3 −2
Original line number Diff line number Diff line
@@ -184,8 +184,9 @@ static void mxc_rtc_irq_enable(struct device *dev, unsigned int bit, 
	struct rtc_plat_data *pdata = dev_get_drvdata(dev);

	void __iomem *ioaddr = pdata->ioaddr;

	u32 reg;

	unsigned long flags;



	spin_lock_irq(&pdata->rtc->irq_lock);

	spin_lock_irqsave(&pdata->rtc->irq_lock, flags);

	reg = readw(ioaddr + RTC_RTCIENR);



	if (enabled)
@@ -194,7 +195,7 @@ static void mxc_rtc_irq_enable(struct device *dev, unsigned int bit, 
		reg &= ~bit;



	writew(reg, ioaddr + RTC_RTCIENR);

	spin_unlock_irq(&pdata->rtc->irq_lock);

	spin_unlock_irqrestore(&pdata->rtc->irq_lock, flags);

}



/* This function is the RTC interrupt service routine. */