Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit a41d9dbf authored by Dan Carpenter's avatar Dan Carpenter Committed by Mark Brown
Browse files

ASoC: qdsp6: q6asm-dai: Fix a small memory leak 



We can't return directly if snd_dma_alloc_pages() fails; we first need
to free prtd->audio_client and prtd.

Fixes: 22930c79 ("ASoC: qdsp6: q6asm-dai: Add support to compress offload")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 3391034e

sound/soc/qcom/qdsp6/q6asm-dai.c

+9 −3
Original line number Diff line number Diff line
@@ -573,8 +573,7 @@ static int q6asm_dai_compr_open(struct snd_compr_stream *stream) 
	if (IS_ERR(prtd->audio_client)) {

		dev_err(dev, "Could not allocate memory\n");

		ret = PTR_ERR(prtd->audio_client);

		kfree(prtd);

		return ret;

		goto free_prtd;

	}



	size = COMPR_PLAYBACK_MAX_FRAGMENT_SIZE *
@@ -583,7 +582,7 @@ static int q6asm_dai_compr_open(struct snd_compr_stream *stream) 
				  &prtd->dma_buffer);

	if (ret) {

		dev_err(dev, "Cannot allocate buffer(s)\n");

		return ret;

		goto free_client;

	}



	if (pdata->sid < 0)
@@ -596,6 +595,13 @@ static int q6asm_dai_compr_open(struct snd_compr_stream *stream) 
	runtime->private_data = prtd;



	return 0;



free_client:

	q6asm_audio_client_free(prtd->audio_client);

free_prtd:

	kfree(prtd);



	return ret;

}



static int q6asm_dai_compr_free(struct snd_compr_stream *stream)