Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 3391034e authored by Dan Carpenter's avatar Dan Carpenter Committed by Mark Brown
Browse files

ASoC: qdsp6: q6asm-dai: Fix a NULL vs IS_ERR() bug 



The q6asm_audio_client_alloc() doesn't return NULL, it returns error
pointers.

Fixes: 22930c79 ("ASoC: qdsp6: q6asm-dai: Add support to compress offload")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent eef08e53

sound/soc/qcom/qdsp6/q6asm-dai.c

+3 −2
Original line number Diff line number Diff line
@@ -570,10 +570,11 @@ static int q6asm_dai_compr_open(struct snd_compr_stream *stream) 
	prtd->audio_client = q6asm_audio_client_alloc(dev,

					(q6asm_cb)compress_event_handler,

					prtd, stream_id, LEGACY_PCM_MODE);

	if (!prtd->audio_client) {

	if (IS_ERR(prtd->audio_client)) {

		dev_err(dev, "Could not allocate memory\n");

		ret = PTR_ERR(prtd->audio_client);

		kfree(prtd);

		return -ENOMEM;

		return ret;

	}



	size = COMPR_PLAYBACK_MAX_FRAGMENT_SIZE *