Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a109c2db authored by Nicholas Mc Guire's avatar Nicholas Mc Guire Committed by Linus Walleij
Browse files

gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack 



The error cases of mediatek_gpio_bank_probe() would go unnoticed (except
for the dev_err() messages). The probe function should return an error
if one of the banks failed to initialize properly indicated by
not returning non-0.

Fixes: 4ba9c3af ("gpio: mt7621: Add a driver for MT7621")
Signed-off-by: default avatarNicholas Mc Guire <hofrat@osadl.org>
Acked-by: default avatarSean Wang <sean.wang@kernel.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 59d646c7

drivers/gpio/gpio-mt7621.c

+6 −2
Original line number Diff line number Diff line
@@ -297,6 +297,7 @@ mediatek_gpio_probe(struct platform_device *pdev) 
	struct device_node *np = dev->of_node;

	struct mtk *mtk;

	int i;

	int ret;



	mtk = devm_kzalloc(dev, sizeof(*mtk), GFP_KERNEL);

	if (!mtk)
@@ -311,8 +312,11 @@ mediatek_gpio_probe(struct platform_device *pdev) 
	platform_set_drvdata(pdev, mtk);

	mediatek_gpio_irq_chip.name = dev_name(dev);



	for (i = 0; i < MTK_BANK_CNT; i++)

		mediatek_gpio_bank_probe(dev, np, i);

	for (i = 0; i < MTK_BANK_CNT; i++) {

		ret = mediatek_gpio_bank_probe(dev, np, i);

		if (ret)

			return ret;

	}



	return 0;

}