Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 59d646c7 authored by Nicholas Mc Guire's avatar Nicholas Mc Guire Committed by Linus Walleij
Browse files

gpio: mt7621: report failure of devm_kasprintf() 



kasprintf() may return NULL on failure of internal allocation thus the
assigned  label  is not safe if not explicitly checked. On error
mediatek_gpio_bank_probe() returns negative values so -ENOMEM in the
(unlikely) failure case should be fine here.

Fixes: 4ba9c3af ("gpio: mt7621: Add a driver for MT7621")
Signed-off-by: default avatarNicholas Mc Guire <hofrat@osadl.org>
Reviewed-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
Acked-by: default avatarSean Wang <sean.wang@kernel.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 46a14b1a

drivers/gpio/gpio-mt7621.c

+2 −0
Original line number Diff line number Diff line
@@ -244,6 +244,8 @@ mediatek_gpio_bank_probe(struct device *dev, 
	rg->chip.of_xlate = mediatek_gpio_xlate;

	rg->chip.label = devm_kasprintf(dev, GFP_KERNEL, "%s-bank%d",

					dev_name(dev), bank);

	if (!rg->chip.label)

		return -ENOMEM;



	ret = devm_gpiochip_add_data(dev, &rg->chip, mtk);

	if (ret < 0) {