Commit 9e421bd9 authored Aug 25, 2022 by Christophe JAILLET Committed by Greg Kroah-Hartman Oct 26, 2022

mmc: au1xmmc: Fix an error handling path in au1xmmc_probe()



[ Upstream commit 5cbedf52608cc3cbc1c2a9a861fb671620427a20 ]

If clk_prepare_enable() fails, there is no point in calling
clk_disable_unprepare() in the error handling path.

Move the out_clk label at the right place.

Fixes: b6507596 ("MIPS: Alchemy: au1xmmc: use clk framework")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/21d99886d07fa7fcbec74992657dabad98c935c4.1661412818.git.christophe.jaillet@wanadoo.fr


Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 9d7af9b1

drivers/mmc/host/au1xmmc.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1116,8 +1116,9 @@ static int au1xmmc_probe(struct platform_device *pdev)
		if (host->platdata && host->platdata->cd_setup &&
		!(mmc->caps & MMC_CAP_NEEDS_POLL))
		host->platdata->cd_setup(mmc, 0);
		out_clk:

		clk_disable_unprepare(host->clk);
		out_clk:
		clk_put(host->clk);
		out_irq:
		free_irq(host->irq, host);