Commit 9d7af9b1 authored Jul 22, 2022 by Liang He Committed by Greg Kroah-Hartman Oct 26, 2022

drm/omap: dss: Fix refcount leak bugs



[ Upstream commit 8b42057e62120813ebe9274f508fa785b7cab33a ]

In dss_init_ports() and __dss_uninit_ports(), we should call
of_node_put() for the reference returned by of_graph_get_port_by_id()
in fail path or when it is not used anymore.

Fixes: 09bffa6e ("drm: omap: use common OF graph helpers")
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220722144348.1306569-1-windhl@126.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 0c55618a

drivers/gpu/drm/omapdrm/dss/dss.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1173,6 +1173,7 @@ static void __dss_uninit_ports(struct dss_device *dss, unsigned int num_ports)
		default:
		break;
		}
		of_node_put(port);
		}
		}

		@@ -1205,11 +1206,13 @@ static int dss_init_ports(struct dss_device *dss)
		default:
		break;
		}
		of_node_put(port);
		}

		return 0;

		error:
		of_node_put(port);
		__dss_uninit_ports(dss, i);
		return r;
		}