Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ca96350 authored by Alok Tiwari's avatar Alok Tiwari Committed by Greg Kroah-Hartman
Browse files

staging: nvec: Fix incorrect null termination of battery manufacturer 



[ Upstream commit a8934352ba01081c51d2df428e9d540aae0e88b5 ]

The battery manufacturer string was incorrectly null terminated using
bat_model instead of bat_manu. This could result in an unintended
write to the wrong field and potentially incorrect behavior.

fixe the issue by correctly null terminating the bat_manu string.

Fixes: 32890b98 ("Staging: initial version of the nvec driver")
Signed-off-by: default avatarAlok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20250719080755.3954373-1-alok.a.tiwari@oracle.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 3bbdc668

drivers/staging/nvec/nvec_power.c

+1 −1
Original line number Diff line number Diff line
@@ -194,7 +194,7 @@ static int nvec_power_bat_notifier(struct notifier_block *nb, 
		break;

	case MANUFACTURER:

		memcpy(power->bat_manu, &res->plc, res->length - 2);

		power->bat_model[res->length - 2] = '\0';

		power->bat_manu[res->length - 2] = '\0';

		break;

	case MODEL:

		memcpy(power->bat_model, &res->plc, res->length - 2);