Commit 9c6850fe authored Nov 06, 2019 by Heiner Kallweit Committed by David S. Miller Nov 06, 2019

r8169: fix page read in r8168g_mdio_read



Functions like phy_modify_paged() read the current page, on Realtek
PHY's this means reading the value of register 0x1f. Add special
handling for reading this register, similar to what we do already
in r8168g_mdio_write(). Currently we read a random value that by
chance seems to be 0 always.

Fixes: a2928d28 ("r8169: use paged versions of phylib MDIO access functions")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 58b87d21

drivers/net/ethernet/realtek/r8169_main.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -916,6 +916,9 @@ static void r8168g_mdio_write(struct rtl8169_private *tp, int reg, int value)

		static int r8168g_mdio_read(struct rtl8169_private *tp, int reg)
		{
		if (reg == 0x1f)
		return tp->ocp_base == OCP_STD_PHY_BASE ? 0 : tp->ocp_base >> 4;

		if (tp->ocp_base != OCP_STD_PHY_BASE)
		reg -= 0x10;